Windows-universal-samples Code Review

ISGroup SRL performed an automated Code Review (not a real Static Analysis, more a grep-on-steroid) of this NodeJS project in order to identify potential security vulnerabilities. We do not guarantee that all the findings are valid, and for sure there are plenty of false-positives and false-negatives (undetected issues) but it's free and your project could benefit from this security analisys. The following data is also available in JSON format!

Possible Security Issues

Issue	Description	Line	File
Key Hardcoded	A hardcoded key in plain text was identified.	88	Samples/WebAuthenticationBroker/js/js/scenario3.js
Key Hardcoded	A hardcoded key in plain text was identified.	160	Samples/WebAuthenticationBroker/js/js/scenario2.js
Key Hardcoded	A hardcoded key in plain text was identified.	216	Samples/WebAuthenticationBroker/js/js/scenario2.js
Key Hardcoded	A hardcoded key in plain text was identified.	60	Samples/CameraAdvancedCapture/js/js/camera.js
Key Hardcoded	A hardcoded key in plain text was identified.	32	Samples/OCR/js/js/scenario2-camera-image.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	93	Samples/IoT-SPI/js/js/scenario1-readdata.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	33	Samples/Inclinometer/js/js/calibrationBar.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	43	Samples/Inclinometer/js/js/scenario2_Polling.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	83	Samples/Inclinometer/js/js/scenario2_Polling.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	33	Samples/Compass/js/js/calibrationBar.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	43	Samples/Compass/js/js/scenario2_Polling.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	86	Samples/Compass/js/js/scenario2_Polling.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	43	Samples/Gyrometer/js/js/scenario2_Polling.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	66	Samples/Gyrometer/js/js/scenario2_Polling.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	57	Samples/IoT-I2C/js/js/scenario1-readdata.js
Key Hardcoded	A hardcoded key in plain text was identified.	53	Samples/CameraFaceDetection/js/js/camera.js
Key Hardcoded	A hardcoded key in plain text was identified.	20	Samples/CustomSensors/js/js/scenario1_DataEvents.js
Key Hardcoded	A hardcoded key in plain text was identified.	21	Samples/CustomSensors/js/js/scenario2_Polling.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	54	Samples/IoT-GPIO/js/js/scenario2-listen.js
Key Hardcoded	A hardcoded key in plain text was identified.	46	Samples/CameraGetPreviewFrame/js/js/camera.js
Key Hardcoded	A hardcoded key in plain text was identified.	51	Samples/CameraStarterKit/js/js/camera.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	43	Samples/LightSensor/js/js/scenario2_Polling.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	64	Samples/LightSensor/js/js/scenario2_Polling.js
Key Hardcoded	A hardcoded key in plain text was identified.	23	Samples/Geolocation/js/geolocationjs/js/scenario4_ForegroundGeofence.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	45	Samples/Accelerometer/js/js/scenario3_Polling.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	66	Samples/Accelerometer/js/js/scenario3_Polling.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	33	Samples/OrientationSensor/js/js/CalibrationBar.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	45	Samples/OrientationSensor/js/js/scenario2_Polling.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	68	Samples/OrientationSensor/js/js/scenario2_Polling.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	17	Samples/WebWorkers/js/js/timers.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	20	Samples/WebWorkers/js/js/timers.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	147	Samples/AllJoyn/ProducerExperiences/js/js/scenario2.js
Key Hardcoded	A hardcoded key in plain text was identified.	10	Samples/AllJoyn/ProducerExperiences/js/js/appdata.js
Key Hardcoded	A hardcoded key in plain text was identified.	11	Samples/AllJoyn/ProducerExperiences/js/js/appdata.js
Key Hardcoded	A hardcoded key in plain text was identified.	12	Samples/AllJoyn/ProducerExperiences/js/js/appdata.js
Key Hardcoded	A hardcoded key in plain text was identified.	13	Samples/AllJoyn/ProducerExperiences/js/js/appdata.js
Key Hardcoded	A hardcoded key in plain text was identified.	14	Samples/AllJoyn/ProducerExperiences/js/js/appdata.js
Key Hardcoded	A hardcoded key in plain text was identified.	15	Samples/AllJoyn/ProducerExperiences/js/js/appdata.js
Key Hardcoded	A hardcoded key in plain text was identified.	16	Samples/AllJoyn/ProducerExperiences/js/js/appdata.js
Password Hardcoded	A hardcoded password in plain text was identified. Store it properly in a config file.	154	Samples/AllJoyn/ProducerExperiences/js/js/appdata.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	226	Samples/SystemMediaTransportControls/js/js/scenario1.js
Key Hardcoded	A hardcoded key in plain text was identified.	60	Samples/CameraVideoStabilization/js/js/camera.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	57	SharedContent/js/Microsoft.WinJS/js/WinJS.intellisense.js
Key Hardcoded	A hardcoded key in plain text was identified.	167	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	1386	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	10029	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	10334	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	20816	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	20817	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	24851	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	30960	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	31242	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	31279	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	33579	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	34226	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	34230	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	34241	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	41145	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	45515	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	45516	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	46869	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	51586	SharedContent/js/Microsoft.WinJS/js/ui.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	173	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	2511	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	4156	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	4164	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	4167	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	5116	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	5135	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	5140	SharedContent/js/Microsoft.WinJS/js/base.js
Key Hardcoded	A hardcoded key in plain text was identified.	6428	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - eval()	User controlled data in eval() can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	8633	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	15378	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	15379	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	15457	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	15458	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	15464	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	16368	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	16369	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	18763	SharedContent/js/Microsoft.WinJS/js/base.js
Server Side Injection(SSI) - new Function()	User controlled data in 'new Function()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	21534	SharedContent/js/Microsoft.WinJS/js/base.js

Issue	Description
Missing Security Header - X-Frame-Options (XFO)	X-Frame-Options (XFO) header provides protection against Clickjacking attacks.
Missing Security Header - Content-Security-Policy (CSP)	Content Security Policy (CSP), a mechanism web applications can use to mitigate a broad class of content injection vulnerabilities, such as cross-site scripting (XSS). CSP Header was not found.
Missing Security Header - Strict-Transport-Security (HSTS)	Strict-Transport-Security (HSTS) header enforces secure (HTTP over SSL/TLS) connections to the server.
Missing 'httpOnly' in Cookie	JavaScript can access Cookies if they are not marked httpOnly.
Infromation Disclosure - X-Powered-By	Remove the X-Powered-By header to prevent information gathering.
Missing Security Header - X-Content-Type-Options	X-Content-Type-Options header prevents Internet Explorer and Google Chrome from MIME-sniffing a response away from the declared content-type.
Missing Security Header - X-Download-Options: noopen	X-Download-Options header set to noopen prevents IE users from directly opening and executing downloads in your site's context.
Missing Security Header - X-XSS-Protection:1	X-XSS-Protection header set to 1 enables the Cross-site scripting (XSS) filter built into most recent web browsers.
Missing Security Header - Public-Key-Pins (HPKP)	Public-Key-Pins (HPKP) ensures that certificate is Pinned.

Node.Security

Security Audit of Windows-universal-samples