Fontello Code Review

ISGroup SRL performed an automated Code Review (not a real Static Analysis, more a grep-on-steroid) of this NodeJS project in order to identify potential security vulnerabilities. We do not guarantee that all the findings are valid, and for sure there are plenty of false-positives and false-negatives (undetected issues) but it's free and your project could benefit from this security analisys. The following data is also available in JSON format!

Possible Security Issues

Issue	Description	Line	File
Key Hardcoded	A hardcoded key in plain text was identified.	177	client/fontello/system/event_actions/event_actions.js
Key Hardcoded	A hardcoded key in plain text was identified.	178	client/fontello/system/event_actions/event_actions.js
Key Hardcoded	A hardcoded key in plain text was identified.	179	client/fontello/system/event_actions/event_actions.js
Key Hardcoded	A hardcoded key in plain text was identified.	180	client/fontello/system/event_actions/event_actions.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	43	client/fontello/system/io_progress/io_progress.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	284	client/fontello/system/navigate/navigate.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	58	client/fontello/system/notify/notify.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	96	client/fontello/system/notify/notify.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	132	client/fontello/system/notify/notify.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	397	client/fontello/app/import/import.js
Key Hardcoded	A hardcoded key in plain text was identified.	10	client/fontello/app/session/session.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	16	client/fontello/layout/layout.js
Weak Hash used - MD5	MD5 is a a weak hash which is known to have collision. Use a strong hashing function.	28	internal/fontello/font_build/font_build.js
Remote OS Command Execution	User controlled data in 'child_process.exec()' can result in Remote OS Command Execution.	125	internal/fontello/font_build/_lib/worker.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	44	lib/system/worker_pool.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	73	lib/system/worker_pool.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	82	lib/system/worker_pool.js
Remote OS Command Execution	User controlled data in 'child_process.exec()' can result in Remote OS Command Execution.	4	lib/system/init/server.js
Weak Hash used - MD5	MD5 is a a weak hash which is known to have collision. Use a strong hashing function.	651	lib/system/runner/initialize.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	344	lib/autoload/hooks/init/service_http.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	414	lib/autoload/hooks/init/service_http.js
Weak Hash used - MD5	MD5 is a a weak hash which is known to have collision. Use a strong hashing function.	117	lib/bundler/index.js
Server Side Injection(SSI) - eval()	User controlled data in eval() can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	30	lib/bundler/plugins/macros.js
Server Side Injection(SSI) - new Function()	User controlled data in 'new Function()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	32	lib/bundler/plugins/macros.js

Issue	Description
Infromation Disclosure - X-Powered-By	Remove the X-Powered-By header to prevent information gathering.
Missing Security Header - X-Content-Type-Options	X-Content-Type-Options header prevents Internet Explorer and Google Chrome from MIME-sniffing a response away from the declared content-type.
Missing Security Header - X-Download-Options: noopen	X-Download-Options header set to noopen prevents IE users from directly opening and executing downloads in your site's context.
Missing Security Header - X-XSS-Protection:1	X-XSS-Protection header set to 1 enables the Cross-site scripting (XSS) filter built into most recent web browsers.
Missing Security Header - Public-Key-Pins (HPKP)	Public-Key-Pins (HPKP) ensures that certificate is Pinned.

Node.Security

Security Audit of Fontello