Openmct Code Review

ISGroup SRL performed an automated Code Review (not a real Static Analysis, more a grep-on-steroid) of this NodeJS project in order to identify potential security vulnerabilities. We do not guarantee that all the findings are valid, and for sure there are plenty of false-positives and false-negatives (undetected issues) but it's free and your project could benefit from this security analisys. The following data is also available in JSON format!

Possible Security Issues

Issue	Description	Line	File
SSRF - Server Side Request Forgery	User controlled data in 'request()'' can result in Server Side Request Forgery (SSRF).	18	app.js
Key Hardcoded	A hardcoded key in plain text was identified.	126	platform/features/plot/test/PlotOptionsControllerSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	127	platform/features/plot/test/PlotOptionsControllerSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	69	platform/features/plot/test/policies/PlotViewPolicySpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	76	platform/features/timeline/test/controllers/TimelineGraphControllerSpec.js
Server Side Injection(SSI) - eval()	User controlled data in eval() can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	39	platform/features/timeline/src/directives/MCTSwimlaneDrag.js
Server Side Injection(SSI) - eval()	User controlled data in eval() can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	104	platform/features/timeline/src/directives/MCTSwimlaneDrop.js
Key Hardcoded	A hardcoded key in plain text was identified.	70	platform/features/imagery/test/policies/ImageryViewPolicySpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	37	platform/core/test/capabilities/CoreCapabilityProviderSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	42	platform/core/test/capabilities/CoreCapabilityProviderSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	88	platform/core/test/capabilities/CoreCapabilityProviderSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	38	platform/core/test/capabilities/PersistenceCapabilitySpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	41	platform/core/test/identifiers/IdentifierSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	53	platform/core/test/actions/ActionProviderSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	60	platform/core/test/actions/ActionProviderSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	73	platform/core/test/actions/ActionProviderSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	108	platform/core/test/types/TypeImplSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	174	platform/representation/test/MCTRepresentationSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	186	platform/representation/test/MCTRepresentationSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	198	platform/representation/test/MCTRepresentationSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	214	platform/representation/test/MCTRepresentationSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	227	platform/representation/test/MCTRepresentationSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	240	platform/representation/test/MCTRepresentationSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	249	platform/representation/test/MCTRepresentationSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	296	platform/representation/test/MCTRepresentationSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	89	platform/representation/test/MCTIncludeSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	94	platform/representation/test/MCTIncludeSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	32	platform/framework/test/load/BundleSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	75	platform/forms/test/MCTControlSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	91	platform/persistence/aggregator/test/PersistenceAggregatorSpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	93	platform/persistence/elastic/src/ElasticPersistenceProvider.js
Server Side Injection(SSI) - eval()	User controlled data in eval() can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	55	platform/commonUI/general/src/directives/MCTClickElsewhere.js
Server Side Injection(SSI) - eval()	User controlled data in eval() can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	66	platform/commonUI/general/src/directives/MCTDrag.js
Server Side Injection(SSI) - eval()	User controlled data in eval() can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	65	platform/commonUI/general/src/directives/MCTResize.js
Server Side Injection(SSI) - eval()	User controlled data in eval() can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	75	platform/commonUI/general/src/directives/MCTResize.js
Key Hardcoded	A hardcoded key in plain text was identified.	72	platform/commonUI/edit/test/policies/EditContextualActionPolicySpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	93	platform/commonUI/edit/test/policies/EditContextualActionPolicySpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	103	platform/commonUI/edit/test/policies/EditContextualActionPolicySpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	114	platform/commonUI/edit/test/policies/EditContextualActionPolicySpec.js
Server Side Injection(SSI) - eval()	User controlled data in eval() can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	53	platform/commonUI/edit/src/directives/MCTBeforeUnload.js
Key Hardcoded	A hardcoded key in plain text was identified.	29	platform/commonUI/dialog/src/OverlayService.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	212	platform/search/src/services/GenericSearchProvider.js
Key Hardcoded	A hardcoded key in plain text was identified.	81	platform/entanglement/test/policies/MovePolicySpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	113	platform/entanglement/test/policies/MovePolicySpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	60	platform/entanglement/test/policies/CopyPolicySpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	82	platform/entanglement/test/policies/CopyPolicySpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	75	platform/entanglement/test/policies/CrossSpacePolicySpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	97	platform/entanglement/test/policies/CrossSpacePolicySpec.js
Key Hardcoded	A hardcoded key in plain text was identified.	87	platform/containment/test/ComposeActionPolicySpec.js

Issue	Description
Missing Security Header - X-Frame-Options (XFO)	X-Frame-Options (XFO) header provides protection against Clickjacking attacks.
Missing Security Header - Content-Security-Policy (CSP)	Content Security Policy (CSP), a mechanism web applications can use to mitigate a broad class of content injection vulnerabilities, such as cross-site scripting (XSS). CSP Header was not found.
Missing Security Header - Strict-Transport-Security (HSTS)	Strict-Transport-Security (HSTS) header enforces secure (HTTP over SSL/TLS) connections to the server.
Missing 'httpOnly' in Cookie	JavaScript can access Cookies if they are not marked httpOnly.
Missing Security Header - X-Content-Type-Options	X-Content-Type-Options header prevents Internet Explorer and Google Chrome from MIME-sniffing a response away from the declared content-type.
Missing Security Header - X-Download-Options: noopen	X-Download-Options header set to noopen prevents IE users from directly opening and executing downloads in your site's context.
Missing Security Header - X-XSS-Protection:1	X-XSS-Protection header set to 1 enables the Cross-site scripting (XSS) filter built into most recent web browsers.
Missing Security Header - Public-Key-Pins (HPKP)	Public-Key-Pins (HPKP) ensures that certificate is Pinned.

Node.Security

Security Audit of Openmct