Statsd Code Review

ISGroup SRL performed an automated Code Review (not a real Static Analysis, more a grep-on-steroid) of this NodeJS project in order to identify potential security vulnerabilities. We do not guarantee that all the findings are valid, and for sure there are plenty of false-positives and false-negatives (undetected issues) but it's free and your project could benefit from this security analisys. The following data is also available in JSON format!

Possible Security Issues

Issue	Description	Line	File
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	217	proxy.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	158	stats.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	428	stats.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	434	stats.js
Key Hardcoded	A hardcoded key in plain text was identified.	448	stats.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	60	test/graphite_legacy_tests_statsprefix.js
Key Hardcoded	A hardcoded key in plain text was identified.	175	test/graphite_legacy_tests_statsprefix.js
Key Hardcoded	A hardcoded key in plain text was identified.	181	test/graphite_legacy_tests_statsprefix.js
Key Hardcoded	A hardcoded key in plain text was identified.	208	test/graphite_legacy_tests_statsprefix.js
Key Hardcoded	A hardcoded key in plain text was identified.	214	test/graphite_legacy_tests_statsprefix.js
Key Hardcoded	A hardcoded key in plain text was identified.	220	test/graphite_legacy_tests_statsprefix.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	60	test/graphite_tests_statsprefix.js
Key Hardcoded	A hardcoded key in plain text was identified.	176	test/graphite_tests_statsprefix.js
Key Hardcoded	A hardcoded key in plain text was identified.	182	test/graphite_tests_statsprefix.js
Key Hardcoded	A hardcoded key in plain text was identified.	209	test/graphite_tests_statsprefix.js
Key Hardcoded	A hardcoded key in plain text was identified.	215	test/graphite_tests_statsprefix.js
Key Hardcoded	A hardcoded key in plain text was identified.	242	test/graphite_tests_statsprefix.js
Key Hardcoded	A hardcoded key in plain text was identified.	248	test/graphite_tests_statsprefix.js
Key Hardcoded	A hardcoded key in plain text was identified.	254	test/graphite_tests_statsprefix.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	54	test/graphite_pickle_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	198	test/graphite_pickle_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	204	test/graphite_pickle_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	208	test/graphite_pickle_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	215	test/graphite_pickle_tests.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	60	test/graphite_legacy_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	174	test/graphite_legacy_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	180	test/graphite_legacy_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	207	test/graphite_legacy_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	213	test/graphite_legacy_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	219	test/graphite_legacy_tests.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	60	test/graphite_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	176	test/graphite_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	182	test/graphite_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	209	test/graphite_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	215	test/graphite_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	219	test/graphite_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	226	test/graphite_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	253	test/graphite_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	280	test/graphite_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	286	test/graphite_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	292	test/graphite_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	320	test/graphite_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	351	test/graphite_tests.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	67	test/graphite_delete_counters_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	182	test/graphite_delete_counters_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	188	test/graphite_delete_counters_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	215	test/graphite_delete_counters_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	221	test/graphite_delete_counters_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	248	test/graphite_delete_counters_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	254	test/graphite_delete_counters_tests.js
Key Hardcoded	A hardcoded key in plain text was identified.	260	test/graphite_delete_counters_tests.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	60	test/graphite_tests_statssuffix.js
Key Hardcoded	A hardcoded key in plain text was identified.	178	test/graphite_tests_statssuffix.js
Key Hardcoded	A hardcoded key in plain text was identified.	184	test/graphite_tests_statssuffix.js
Key Hardcoded	A hardcoded key in plain text was identified.	211	test/graphite_tests_statssuffix.js
Key Hardcoded	A hardcoded key in plain text was identified.	217	test/graphite_tests_statssuffix.js
Key Hardcoded	A hardcoded key in plain text was identified.	244	test/graphite_tests_statssuffix.js
Key Hardcoded	A hardcoded key in plain text was identified.	250	test/graphite_tests_statssuffix.js
Key Hardcoded	A hardcoded key in plain text was identified.	256	test/graphite_tests_statssuffix.js
Server Side Injection(SSI) - eval()	User controlled data in eval() can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	19	lib/config.js

Missing Security Features

Issue	Description
Missing Security Header - X-Frame-Options (XFO)	X-Frame-Options (XFO) header provides protection against Clickjacking attacks.
Missing Security Header - Content-Security-Policy (CSP)	Content Security Policy (CSP), a mechanism web applications can use to mitigate a broad class of content injection vulnerabilities, such as cross-site scripting (XSS). CSP Header was not found.
Use Strict	Strict Mode allows you to place a program, or a function, in a "strict" operating context. This strict context prevents certain actions from being taken and throws more exceptions.
Missing Security Header - Strict-Transport-Security (HSTS)	Strict-Transport-Security (HSTS) header enforces secure (HTTP over SSL/TLS) connections to the server.
Missing 'httpOnly' in Cookie	JavaScript can access Cookies if they are not marked httpOnly.
Infromation Disclosure - X-Powered-By	Remove the X-Powered-By header to prevent information gathering.
Missing Security Header - X-Content-Type-Options	X-Content-Type-Options header prevents Internet Explorer and Google Chrome from MIME-sniffing a response away from the declared content-type.
Missing Security Header - X-Download-Options: noopen	X-Download-Options header set to noopen prevents IE users from directly opening and executing downloads in your site's context.
Missing Security Header - X-XSS-Protection:1	X-XSS-Protection header set to 1 enables the Cross-site scripting (XSS) filter built into most recent web browsers.
Missing Security Header - Public-Key-Pins (HPKP)	Public-Key-Pins (HPKP) ensures that certificate is Pinned.

Node.Security

Security Audit of Statsd